Pair Programming, PR Tips, File Icons, and Zed's Architecture

By effectively engaging with the Zed team and community early in your process, we're better positioned to give you feedback and understand your pull request once you open it. If the first thing we see from you is a big changeset, we're much less likely to respond to it in a timely manner. ## Pair programming We plan to set aside time each week to pair program with contributors on promising pull requests in Zed. This will be an experiment. We tend to prefer pairing over async code review on our team, and we'd like to see how well it works in an open source setting. If we're finding it difficult to get on the same page with async review, we may ask you to pair with us if you're open to it. The closer a contribution is to the goals outlined in our roadmap, the more likely we'll be to spend time pairing on it. ## Tips to improve the chances of your PR getting reviewed and merged - Discuss your plans ahead of time with the team - Small, focused, incremental pull requests are much easier to review - Spend time explaining your changes in the pull request body - Add test coverage and documentation - Choose tasks that align with our roadmap - Pair with us and watch us code to learn the codebase - Low effort PRs, such as those that just re-arrange syntax, won't be merged without a compelling justification ## File icons Zed's default icon theme consists of icons that are hand-designed to fit together in a cohesive manner. We do not accept PRs for file icons that are just an off-the-shelf SVG taken from somewhere else. ### Adding new icons to the Zed icon theme If you would like to add a new icon to the Zed icon theme, [open a Discussion](https://github.com/zed-industries/zed/discussions/new?category=ux-and-design) and we can work with you on getting an icon designed and added to Zed. ## Bird's-eye view of Zed Zed is made up of several smaller crates - let's go over those you're most likely to interact with: - [`gpui`](/crates/gpui) is a GPU-accelerated UI framework which provides all of the building blocks for Zed. **We recommend familiarizing yourself with the root level GPUI documentation.** - [`editor`](/crates/editor) contains the core `Editor` type that drives both the code editor and all various input fields within Zed. It also handles a display layer for LSP features such as Inlay Hints or code completions. - [`project`](/crates/project) manages files and navigation within the filetree. It is also Zed's side of communication with LSP. - [`workspace`](/crates/workspace) handles local state serialization and groups projects together. - [`vim`](/crates/vim) is a thin implementation of Vim workflow over `editor`. - [`lsp`](/crates/lsp) handles communication with external LSP server. - [`language`](/crates/language) drives `editor`'s understanding of language - from providing a list of symbols to the syntax map. - [`collab`](/crates/collab) is the collaboration server itself, driving the collaboration features such as project sharing. - [`rpc`](/crates/rpc) defines messages to be exchanged with collaboration server. - [`theme`](/crates/theme) defines the theme system and provides a default theme. - [`ui`](/crates/ui) is a collection of UI components and common patterns used throughout Zed. - [`cli`](/crates/cli) is the CLI crate which invokes the Zed binary. - [`zed`](/crates/zed) is where all things come together, and the `main` entry point for Zed. ## Packaging Zed Check our [notes for packaging Zed](https://zed.dev/docs/development/linux#notes-for-packaging-zed).

This section discusses the benefits of early engagement with the Zed team, the potential for pair programming on promising PRs, and offers tips to improve the chances of PR acceptance, such as discussing plans, submitting small, focused PRs, and aligning with the roadmap. It also covers guidelines for file icon contributions, emphasizing the need for hand-designed icons. Furthermore, it provides an overview of Zed's architecture, detailing key crates like `gpui`, `editor`, `project`, `workspace`, `vim`, `lsp`, `language`, `collab`, `rpc`, `theme`, `ui`, `cli`, and `zed`, and links to notes for packaging Zed.